Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QR code functionality from CLI #6370

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

johanstokking
Copy link
Member

@johanstokking johanstokking commented Jul 4, 2023

Summary

Closes #6345

Changes

  • Remove QR code format listing and generation from CLI and hide the commands. These commands were marked EXPERIMENTAL so we can do anything with them
  • Hide provision command; it still works and we can't remove it as it wasn't EXPERIMENTAL

Testing

N/A

Regressions

Users and scripts depending on this command will stop working, but because of the way they were marked, the compatibility commitment does not apply.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@johanstokking johanstokking added this to the v3.27.0 milestone Jul 4, 2023
@johanstokking johanstokking self-assigned this Jul 4, 2023
@github-actions github-actions bot added the ui/cli This is related to ttn-lw-cli label Jul 4, 2023
@johanstokking johanstokking merged commit 285bcc4 into v3.27 Jul 4, 2023
@johanstokking johanstokking deleted the feature/6345-cli-generate-qr-deprecation branch July 4, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/cli This is related to ttn-lw-cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate generate-qr command for end devices
2 participants